Skip to content

Conversation

@MichalStrehovsky
Copy link
Member

Just curious what breaks.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 11, 2025
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@MichalStrehovsky
Copy link
Member Author

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hez2010
Copy link
Contributor

hez2010 commented Feb 11, 2025

You may want to remove here as well, otherwise GVM inlinees will be rejected later:

if ((mflags & CORINFO_FLG_VIRTUAL) && (sig->sigInst.methInstCount != 0) && (opcode == CEE_CALLVIRT))
{
compInlineResult->NoteFatal(InlineObservation::CALLEE_IS_GENERIC_VIRTUAL);
return TYP_UNDEF;
}

@MichalStrehovsky
Copy link
Member Author

You may want to remove here as well, otherwise GVM inlinees will be rejected later:

I'm not after GVMs, just regular interface calls (#112406 is the work, this PR is just a check).

@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-3 branch February 11, 2025 22:23
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants