Skip to content

Build the RID-specific System.IO.Ports packages in the VMR #112054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Build the RID-specific System.IO.Ports packages in the VMR #112054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions src/libraries/oob-src.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,18 @@
<TargetFramework>$(NetCoreAppCurrent)-$(TargetOS)</TargetFramework>
<!-- Filter ProjectReferences to build the best matching target framework only. -->
<FilterTraversalProjectReferences>true</FilterTraversalProjectReferences>
<!-- In non-official builds, build RID-specific projects -->
<BuildRidSpecificProjects Condition="'$(BuildingAnOfficialBuildLeg)' != 'true'">true</BuildRidSpecificProjects>
<!-- In the VMR, we're always in a RID-specific leg. -->
<BuildRidSpecificProjects Condition="'$(BuildRidSpecificProjects)' == '' and
'$(DotNetBuildOrchestrator)' == 'true'">true</BuildRidSpecificProjects>
<!--
Outside the VMR, only RID-specific packages in official build legs when we're not building AllConfigurations,
but we're building everything for this RID target (ie don't build on specialized legs like Mono LLVMAOT).
-->
<BuildRidSpecificProjects Condition="'$(BuildRidSpecificProjects)' == '' and
'$(BuildAllConfigurations)' != 'true' and
'$(DotNetBuildAllRuntimePacks)' == 'true'">true</BuildRidSpecificProjects>
</PropertyGroup>

<!-- Reference all NetCoreAppCurrent out-of-band src projects. -->
Expand All @@ -19,13 +31,7 @@
The limitation on DotNetBuildAllRuntimePacks avoids duplicate assets being publish. -->
<ProjectReference Include="$(MSBuildThisFileDirectory)*\pkg\runtime.$(OutputRID).*.proj"
Condition="'$(SkipLibrariesNativeRuntimePackages)' != 'true' and
(
'$(BuildingAnOfficialBuildLeg)' != 'true' or
(
'$(BuildAllConfigurations)' != 'true' and
'$(DotNetBuildAllRuntimePacks)' == 'true'
)
)" />
'$(BuildRidSpecificProjects)' == 'true'" />

<!-- Don't build task and tools project in the NetCoreAppCurrent vertical. -->
<ProjectReference Remove="Microsoft.XmlSerializer.Generator\src\Microsoft.XmlSerializer.Generator.csproj" />
Expand Down