Skip to content

JIT: Don't run optSetBlockWeights when we have PGO data #111764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2025
Merged

JIT: Don't run optSetBlockWeights when we have PGO data #111764

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
519718b
Don't run optSetBlockWeights when we have PGO data
amanasifkhalid Jan 23, 2025
7d6c334
Merge branch 'main' into skip-optSetBlockWeights
amanasifkhalid Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/coreclr/jit/optimizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,20 @@ DataFlow::DataFlow(Compiler* pCompiler)
PhaseStatus Compiler::optSetBlockWeights()
{
noway_assert(opts.OptimizationEnabled());
assert(m_dfsTree != nullptr);
const bool usingProfileWeights = fgIsUsingProfileWeights();

// Rely on profile synthesis to propagate weights when we have PGO data.
// TODO: Replace optSetBlockWeights with profile synthesis entirely.
if (usingProfileWeights)
{
// Leave breadcrumb for loop alignment
fgHasLoops = m_dfsTree->HasCycle();
return PhaseStatus::MODIFIED_NOTHING;
}

bool madeChanges = false;

assert(m_dfsTree != nullptr);
if (m_domTree == nullptr)
{
m_domTree = FlowGraphDominatorTree::Build(m_dfsTree);
Expand All @@ -59,8 +70,7 @@ PhaseStatus Compiler::optSetBlockWeights()
optFindAndScaleGeneralLoopBlocks();
}

bool firstBBDominatesAllReturns = true;
const bool usingProfileWeights = fgIsUsingProfileWeights();
bool firstBBDominatesAllReturns = true;

fgComputeReturnBlocks();

Expand Down
Loading