Fail tests if LTCG is used #111651
Merged
Fail tests if LTCG is used #111651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet#111566 is not the first time we accidentally shipped something built with LTCG. We should ideally not allow merging such code into `main`.
ghost
added
the
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
Member
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
I assume that we should see this failing (in outer loop at least) until #111566 gets fixed. Is that right? |
Member
It does not appear to be failing as expected. |
Member
Author
Yep, it was supposed to fail. Operator error. |
MichalStrehovsky
added
the
NO-MERGE
Member
Author
|
Yup, now failing as expected. Marked as no merge until #111566 is fixed. |
jkotas
reviewed
Jan 22, 2025
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets
Outdated
Show resolved
Hide resolved
MichalStrehovsky
removed
the
NO-MERGE
jkotas
approved these changes
Feb 3, 2025
This was referenced Feb 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#111566 is not the first time we accidentally shipped something built with LTCG. We should ideally not allow merging such code into
main.Cc @dotnet/ilc-contrib