Skip to content

[release/9.0-staging] Fix UNC paths #111499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: [manual] Merge release/9.0-staging into release/9.0
merged 5 commits into from
Feb 3, 2025
Merged

[release/9.0-staging] Fix UNC paths #111499

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3e0fc9c
Fix UNC paths
agocke Nov 21, 2024
aba2563
Use MAXPATH instead
agocke Dec 6, 2024
a1f45d7
Update src/native/corehost/hostmisc/pal.windows.cpp
agocke Dec 7, 2024
4696e22
Update src/native/corehost/hostmisc/pal.windows.cpp
agocke Dec 10, 2024
449f384
Merge branch 'release/9.0-staging' into backport/pr-110033-to-release…
agocke Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/native/corehost/hostmisc/pal.windows.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,8 +884,12 @@ bool pal::realpath(pal::string_t* path, bool skip_error_logging)
}
}

// Remove the \\?\ prefix, unless it is necessary or was already there
if (LongFile::IsExtended(str) && !LongFile::IsExtended(*path) &&
// Remove the UNC extended prefix (\\?\UNC\) or extended prefix (\\?\) unless it is necessary or was already there
if (LongFile::IsUNCExtended(str) && !LongFile::IsUNCExtended(*path) && str.length() < MAX_PATH)
{
str.replace(0, LongFile::UNCExtendedPathPrefix.size(), LongFile::UNCPathPrefix);
}
else if (LongFile::IsExtended(str) && !LongFile::IsExtended(*path) &&
!LongFile::ShouldNormalize(str.substr(LongFile::ExtendedPrefix.size())))
{
str.erase(0, LongFile::ExtendedPrefix.size());
Expand Down
Loading