Skip Init and Static helpers when looking for a caller #111446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have learned that real world code may call Assembly.GetCallingAssembly in a static constructor. It returns different value now that there is an extra managed frame introduced by HMF removal. The fix adds the managed helper types to the long ad-hoc list of types that should be skipped for this and similar APIs. It does not change the fact that Assembly.GetCallingAssembly is a slow fragile unreliable API that should not be used. Fixes dotnet#111399
ghost
added
the
|
@jkotas do you want to write a regression test for this? This is a rather odd corner case that looks easy to break in the future to me. |
davidwrighton
approved these changes
Jan 15, 2025
It sounds like we might want a test for the reflection list that Jan added to. I agree this seems very fragile and the API should be avoided. |
AaronRobinsonMSFT
approved these changes
Jan 15, 2025
AaronRobinsonMSFT
approved these changes
Jan 15, 2025
This was referenced Jan 16, 2025
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have learned that real world code may call Assembly.GetCallingAssembly in a static constructor. It returns different value now that there is an extra managed frame introduced by HMF removal. The fix adds the managed helper types to the long ad-hoc list of types that should be skipped for this and similar APIs. It does not change the fact that Assembly.GetCallingAssembly is a slow fragile unreliable API that should not be used.
Fixes #111399