Remove HttpMetricsEnrichmentContext caching #110580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 10, 2024
Closed
|
/backport to release/9.0-staging |
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/12284286138 |
This was referenced Dec 11, 2024
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/12285016129 |
hez2010
pushed a commit
to hez2010/runtime
that referenced
this pull request
Dec 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108284
With this change the
HttpMetricsEnrichmentContextis only used while we're running the callbacks, we're no longer storing it on the request properties.As it's now much more short lived, and doesn't carry as much state (no
Lists), there's no point in pooling it.The change does introduce a bit more allocations as we're now allocating a
List<Callback>per request.If we care, we can add the extra logic to avoid the list allocation when there's just 1 callback.
I'm also using the
TagListdirectly since we're not pooling theListanymore. I think this should still be fine since its default capacity is 8 before allocating more, and we're only adding ~5 tags, so there's room for user-provided ones.