Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Remove DiagnosticSource reference from Microsoft.Extensions.Logging.Abstractions #110458

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Dec 5, 2024

Fixes #110401

Customer Impact

  • Customer reported
  • Found internally

Unnecessary unused dependency added on <= net7.0, .netstandard, .netframework with the following impact to customer:

  • Requires more bindingRedirects
  • Increased application size (185 KB)
  • Additional license implications

Regression

  • Yes (regressed in 8.0.2 compared to 8.0.1)
  • No

Testing

Build to validate unused dependency is removed.

Risk

Very low. Removing an unused dependency that's only shipped in one release.

…bstractions

This was inadvertently added in backport but was not needed.
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

@carlossanlop carlossanlop added the Servicing-consider Issue for next servicing release review label Dec 5, 2024
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Dec 10, 2024
@rbhanda rbhanda added this to the 8.0.13 milestone Dec 10, 2024
@ericstj ericstj merged commit 1a0aa3b into release/8.0-staging Dec 17, 2024
103 of 113 checks passed
@KalleOlaviNiemitalo
Copy link

When is 8.0.13 scheduled to be released? From the dates in https://github.com/dotnet/core/blob/main/release-notes/8.0/README.md, I guess the second Tuesday of January 2025.

@jkotas jkotas deleted the ericstj/noDiagnosticSourceMELA branch December 29, 2024 15:51
@KalleOlaviNiemitalo
Copy link

8.0.12 was released today. I guess 8.0.13 will come in February, then.

@tarekgh
Copy link
Member

tarekgh commented Jan 14, 2025

8.0.12 was released today. I guess 8.0.13 will come in February, then.

Yes, it will be around Feb 11th or so.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-Logging Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants