Support generic fields in PersistedAssemblyBuilder

[steveharter]

Fixes #110247

cc @jgh07

We will likely port to v9.x once verified in v10 since this was new functionality in v9.

[Copilot]

Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

src/libraries/System.Reflection.Emit/tests/PersistedAssemblyBuilder/AssemblySaveTypeBuilderTests.cs:244

• The constructor call should use Type.EmptyTypes for clarity and to avoid potential issues with different runtime environments.

il.Emit(OpCodes.Newobj, declaringType.GetConstructor([]));

[buyaa-n]

LGTM, thanks!

[jkotas]

https://github.com/dotnet/runtime/pull/110372/files#r1876967406

[steveharter]

/backport to release/9.0-staging

[github-actions]

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/12415232737

[ericstj]

@jkotas @steveharter - do you think we need to add more test cases to cover other permutations of generic usage? Methods / properties / events / parameters, nested generics, etc.

[jkotas]

It is a lot of potentially interesting permutations. The chances of more broken corner-cases being found by manual test authoring are low. I think that the best way to find more broken corner-cases is roundtripping of the existing test asserts through ref.emit and validating that the roundtripped tests still pass. Buya has done some of it, but it was not completed and automated.

[buyaa-n]

do you think we need to add more test cases to cover other permutations of generic usage? Methods / properties / events / parameters, nested generics, etc.

I added as much test as I can that covers many permutations of generic usage and nested generics for methods and its parameter. Agree with Jan that to find more corner cases round tripping tool would have been helpful. As mentioned the tool was used locally, not added into the repo and now that project is gone with my old laptop. Someone could rewrite it using the .NET framework tool.

We don't have tests that calling generic properties / events in IL, because by my understanding properties / events are not called directly in IL, at least not with ref emit APIs, instead their get/set/add/remove methods are called/used in IL, and those are covered by methods tests.