Skip to content

Conversation

@sbomer
Copy link
Member

@sbomer sbomer commented Oct 29, 2024

Fixes a discrepancy where coreclr marshals empty blittable arrays as non-null, but native AOT marshals them as null. With the fix, native AOT marshals them as non-null.

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

@MichalStrehovsky
Copy link
Member

Maybe this is fixing #81674? I don't know if there's more issues after this one, but the error message in the issue looks suspiciously related:

============ [CStyle_Array_Int_InOut_ZeroLength] ============
[CStyle_Array_Int_InOut_ZeroLength] Error: parameter actual is NULL

Might be worth removing the ActiveIssue/issues.targets entries to see if the test can pass now.

@sbomer
Copy link
Member Author

sbomer commented Oct 30, 2024

I don't know if there's more issues after this one, but the error message in the issue looks suspiciously related:

Tried enabling that test - it looks like we get past that particular error, but then it fails later in TestMarshalByVal_Out.

@sbomer sbomer merged commit f7cceb0 into dotnet:main Oct 30, 2024
94 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants