handle case of Proc Index > MAX_SUPPORTED_CPUS #109295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsharm
reviewed
Oct 29, 2024
| uint32_t proc_no = GCToOSInterface::GetCurrentProcessorNumber(); | ||
| int adjusted_heap = proc_no_to_heap_no[proc_no]; | ||
| // proc_no could likely exceed MAX_SUPPORTED_CPUS on x86 | ||
| int adjusted_heap = proc_no_to_heap_no[proc_no % MAX_SUPPORTED_CPUS]; |
There was a problem hiding this comment.
I know this was code from before but do we need adjusted_heap to be signed? Will there ever be a case where adjusted_heap is negative?
There was a problem hiding this comment.
don't believe that could occur.
Maoni0
reviewed
Oct 29, 2024
|
/backport to release/9.0-staging |
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/11600698630 |
4 tasks
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/11600735639 |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this issue affects x86 apps running on machine with > 64 cores.