Skip to content

Conversation

lewing
Copy link
Member

@lewing lewing commented Oct 28, 2024

No description provided.

@lewing lewing added this to the 9.0.1 milestone Oct 28, 2024
@lewing lewing requested review from marcpopMSFT and wtgodbe October 28, 2024 16:50
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 28, 2024
@lewing lewing added area-Workloads Workloads like wasm-tools and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 28, 2024
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lewing - Please retarget this PR to the release/9.0-staging branch.

You can retarget to that branch by clicking on the Edit button on the top right (next to the PR title) and choosing the release/9.0-staging branch from the dropdown. Important: Please make sure you don't bring any unrelated changes from the release/9.0 branch when retargeting to release/9.0-staging.

<PatchVersion>0</PatchVersion>
<SdkBandVersion>9.0.100</SdkBandVersion>
<PackageVersionNet8>8.0.11</PackageVersionNet8>
<PackageVersionNet8>8.0.$([MSBuild]::Add($([System.Version]::Parse('$(ProductVersion)').Build),11))</PackageVersionNet8>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want PatchVersion here and not ProductVersion

Copy link
Member Author

@lewing lewing Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It parses the ProductVersion, at least in 8.0 that also changed? Is there some reason it is still 9.0.0 here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, I just saw the productversion and didn't notice the parse. Does parsing that and grabbing build do the right thing? I actually don't know.

@carlossanlop
Copy link
Contributor

We'll merge the other one instead of this one: #110586

@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Workloads Workloads like wasm-tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants