Move IsDebuggerPresent to minipal, convert to QCall #108837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
am11
force-pushed
the
feature/minipal_is_native_debugger_present
branch
from
41174d8 to
c7cf37d
Compare
dotnet-policy-service
bot
added
the
community-contribution
am11
added
area-PAL-coreclr
and removed
needs-area-label
am11
force-pushed
the
feature/minipal_is_native_debugger_present
branch
12 times, most recently
from
7c113c7 to
2084bcc
Compare
| add_executable_clr(corerun | ||
| corerun.cpp | ||
| dotenv.cpp | ||
| ${CLR_SRC_NATIVE_DIR}/minipal/is_native_debugger_present.c |
Member
There was a problem hiding this comment.
Wasn't there some effort to make the minipal and static lib?
Member
Author
There was a problem hiding this comment.
Yes whichever PR is merged first, the other one will need to resolve conflicts as we usually do. :)
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Diagnostics/Debugger.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/Diagnostics/Debugger.cs
Outdated
Show resolved
Hide resolved
This was referenced Oct 14, 2024
Closed
Closed
am11
force-pushed
the
feature/minipal_is_native_debugger_present
branch
from
3198cea to
167799b
Compare
jkotas
reviewed
Oct 15, 2024
src/coreclr/System.Private.CoreLib/src/System/Diagnostics/Debugger.cs
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Diagnostics/Debugger.cs
Outdated
Show resolved
Hide resolved
am11
force-pushed
the
feature/minipal_is_native_debugger_present
branch
2 times, most recently
from
c3e6998 to
4f18d67
Compare
am11
force-pushed
the
feature/minipal_is_native_debugger_present
branch
from
4f18d67 to
669a148
Compare
am11
force-pushed
the
feature/minipal_is_native_debugger_present
branch
from
669a148 to
e8a3879
Compare
Member
Author
|
Wasm builds timed out on Azure DevOps (GitHub keeps showing them as running). Wasm errors are either known or timeout related according to /ba. |
This was referenced Oct 15, 2024
Member
AaronRobinsonMSFT
left a comment
AaronRobinsonMSFT
left a comment
There was a problem hiding this comment.
Other than the minor Nit and outstanding question to Jan, I'm signed off. I'll approve once I get his feedback on my question.
Co-authored-by: Aaron Robinson <[email protected]>
AaronRobinsonMSFT
approved these changes
Oct 15, 2024
This was referenced Oct 15, 2024
noahfalk
approved these changes
Oct 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minipal_is_native_debugger_presentand clean up the code across the coreclr, mono, and nativeaot implementations.