-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete STUBLINKER_GENERATES_UNWIND_INFO #108684
Open
jkotas
wants to merge
7
commits into
dotnet:main
Choose a base branch
from
jkotas:STUBLINKER_GENERATES_UNWIND_INFO
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+70
−3,050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of the stublinker stubs need this anymore
jkotas
changed the title
Stublinker generates unwind info
@jkotas Delete STUBLINKER_GENERATES_UNWIND_INFO
Oct 8, 2024
jkotas
changed the title
@jkotas Delete STUBLINKER_GENERATES_UNWIND_INFO
Delete STUBLINKER_GENERATES_UNWIND_INFO
Oct 8, 2024
Tagging subscribers to this area: @mangod9 |
@jkotas Is there any impact to R2R for x86? |
3 tasks
This change is no-op for x86. The stub unwind info was not emitted on x86 before this change (both Windows and non-Windows). |
jkotas
force-pushed
the
STUBLINKER_GENERATES_UNWIND_INFO
branch
from
October 8, 2024 22:08
4f82273
to
15f746a
Compare
jkotas
force-pushed
the
STUBLINKER_GENERATES_UNWIND_INFO
branch
from
October 9, 2024 04:01
de085ec
to
2bc6419
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of the stublinker stubs need this anymore