Fix GCStart message in StressLog and StressLogAnalyzer #108655
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CI to avoid breaks
…s 64-bit floating point values)
markples
commented
Oct 8, 2024
markples
commented
Oct 8, 2024
| @@ -1299,6 +1295,7 @@ int ProcessStressLog(void* baseAddress, int argc, char* argv[]) | |||
| memset(&mapImageToStringId, 0, sizeof(mapImageToStringId)); | |||
| memset(s_interestingStringFilter, 0, sizeof(s_interestingStringFilter)); | |||
| memset(s_interestingStringMatchMode, 0, sizeof(s_interestingStringMatchMode)); | |||
| s_interestingStringMatchMode[IS_GCSTART] = true; | |||
There was a problem hiding this comment.
This is an unfortunate detail to have here, but I don't think we want to generalize the InterestingStrings table to have a prefix bool.
There was a problem hiding this comment.
This will be a little easier to do in the managed implementation I think.
This was referenced Oct 8, 2024
3 tasks
markples
commented
Oct 8, 2024
markples
commented
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcDetailedStartMsgto fit under the 16-argument limit for the stress log but keep all arguments forSIMPLE_DPRINTFgcDetailedStartMsgTRACE_GCpipeline buildIncludes #108089 until it is merged
Fixes #108628