-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0] [wasm] Fixes for issue #108519 #108650
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @dlemstra |
pavelsavara
added
arch-wasm
WebAssembly architecture
os-browser
Browser variant of arch-wasm
labels
Oct 8, 2024
Tagging subscribers to 'arch-wasm': @lewing |
lewing
approved these changes
Oct 8, 2024
jeffschwMSFT
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. we will take for consideration in 9 GA
leecow
added
Servicing-approved
Approved for servicing release
and removed
Servicing-consider
Issue for next servicing release review
labels
Oct 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
arch-wasm
WebAssembly architecture
area-Codegen-Interpreter-mono
os-browser
Browser variant of arch-wasm
Servicing-approved
Approved for servicing release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #108543 to release/9.0
/cc @kg
Customer Impact
A customer experiences a crash (#108519) during their startup which appears to be caused by a method being destroyed before the jiterpreter has initialized; this causes the jiterpreter's cleanup code to crash because its data structures are missing. No repro was provided.
Regression
Introduced by the Jiterpreter.
Testing
Customer needs a runtime build to verify fix
Risk
Low risk. Does not add new functionality or enable existing functionality in new places.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging
, notrelease/X.0
.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.