Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stack 2x2 tensor along dimension 1 #108620

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kasperk81
Copy link
Contributor

fix #108615

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 7, 2024
@kasperk81
Copy link
Contributor Author

was

System.Numerics.Tensors.Tests.TensorTests.TensorStackTests [FAIL]
  Assert.Equal() Failure: Values differ
  Expected: 10
  Actual:   1

now passing

@kasperk81 kasperk81 marked this pull request as ready for review October 7, 2024 20:34
@kasperk81
Copy link
Contributor Author

@tannergooding, @michaelgsharp, @carlossanlop
another new .net 9 api bug fix. is backport warranted for this pr?

@MihaZupan
Copy link
Member

Does this part have a similar issue ([0] index + outputs being ignored)?

Tensor<T>[] outputs = new Tensor<T>[tensors.Length];
for (int i = 0; i < tensors.Length; i++)
{
outputs[i] = Tensor.Unsqueeze(tensors[0], dimension);
}
return ref Tensor.ConcatenateOnDimension<T>(dimension, tensors, destination);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Numerics.Tensors community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StackAlongDimension does not return correct result
2 participants