use SpecialFolder.UserProfile instead of USERPROFILE #108559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-dependencymodel |
3 tasks
kasperk81
commented
Oct 17, 2024
| { | ||
| basePath = environment.GetEnvironmentVariable("HOME"); | ||
| } | ||
| string basePath = Environment.GetFolderPath(Environment.SpecialFolder.UserProfile); |
There was a problem hiding this comment.
@ViktorHofer this is matching sdk and nuget streamlined behavior NuGet/NuGet.Client@310f5d4 dotnet/sdk@456aa42 using standard .net api to get profile directory cross platform instead of manually checking the environment variables.
There was a problem hiding this comment.
I don't really have much context here but the changes LGTM
ViktorHofer
approved these changes
Nov 8, 2024
|
@kasperk81 this test failure looks related:
|
2 tasks
ViktorHofer
approved these changes
Nov 11, 2024
|
Thanks @kasperk81 |
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
* use SpecialFolder.UserProfile instead of USERPROFILE * Update PackageResolverTest.cs * Update PackageResolverTest.cs * Update src/libraries/Microsoft.Extensions.DependencyModel/tests/PackageResolverTest.cs * Update PackageResolverTest.cs --------- Co-authored-by: Viktor Hofer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.