Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix devirtualization across genericness in the hierarchy #108442

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Fix devirtualization across genericness in the hierarchy #108442

merged 1 commit into from
Oct 1, 2024
+37 −6

Commits on Oct 1, 2024

  1. Fix devirtualization across genericness in the hierarchy 

    This code was trying to answer question: "Was this method overriden by something else in a more derived class"? It was walking the base hierarchy in canonical form, but that was leading to methods not resolving at all. The fix is to walk the non-canonical hierarchy and canonicalize after we resolved everything.

I ran into this in dotnet#108379 that unlocked more whole program devirtualization and `StringSearchValuesBase` is in this shape.
    @MichalStrehovsky
    MichalStrehovsky committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    1cec738 View commit details
    Browse the repository at this point in the history