Call native BrotliEncoderMaxCompressedSize method for BrotliEncoder.GetMaxCompressedLength #108043
+28
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etMaxCompressedLength
This was referenced Sep 20, 2024
stephentoub
reviewed
Oct 5, 2024
| @@ -11,7 +11,7 @@ internal static partial class BrotliUtils | |||
| public const int Quality_Min = 0; | |||
| public const int Quality_Default = 4; | |||
| public const int Quality_Max = 11; | |||
| public const int MaxInputSize = int.MaxValue - 515; // 515 is the max compressed extra bytes | |||
| public const int MaxInputSize = int.MaxValue - 524_166; // 524_166 is the max compressed extra bytes | |||
There was a problem hiding this comment.
Where does this number come from?
There was a problem hiding this comment.
Before int.MaxValue - 515 = 2_147_483_132 was producing max compressed length, i.e. GetMaxCompressedLength(2_147_483_132)) returned int.MaxValue. Now this produces negative number
After testing with various values now this value equals 524_166 and GetMaxCompressedLength(int.MaxValue - 524_166))producesint.MaxValue`
The comment is not that clear, but do not have a better version
stephentoub
approved these changes
Oct 5, 2024
This was referenced Oct 7, 2024
|
/ba-g test failures in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BrotliEncoder.GetMaxCompressedLengthreturns invalid value for some input because managed implementation differs from native Brotli native implementation that updated many years agoAs discussed in the issue we should use the native implementation since it's the source of truth, and this size needs to remain in sync with what the encoder actually does.
Fixes #35142