Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] Arm64/Sve: Remove entries of SVE APIs take 32-bit address #107780

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

kunalspathak
Copy link
Member

Backport of #107758 to release/9.0

Customer Impact

  • Customer reported
  • Found internally

We have disabled several APIs that takes 32-bit address as input parameter because of lack of testing of such address. However, there were few APIs that were not disabled. This PR disables such APIs, until we add relevant test coverage in future release.

Regression

  • Yes
  • No

This is not a regression, but merely something that was not disabled.

Testing

The build works and all the tests that were using the APIs are commented out.

Risk

Low. This only affects SVE APIs that were enabled in earlier previews but are disabled because they are untested. Besides, SVE is an experimental feature for .NET 9.

Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@kunalspathak
Copy link
Member Author

Something is off with my branch.

)

* Remove entry of APIs because of dotnet#103297

* comment out the test cases for unsupported APIs
@kunalspathak kunalspathak changed the base branch from main to release/9.0 September 13, 2024 04:51
@kunalspathak
Copy link
Member Author

Something is off with my branch.

fixed the base to release/9.0

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.

please file a breaking change between RC1 and RC2 for these removals. (even though this is a preview feature)

we can merge when ready

@jeffschwMSFT jeffschwMSFT added the Servicing-approved Approved for servicing release label Sep 13, 2024
@jeffschwMSFT jeffschwMSFT merged commit 15ef393 into dotnet:release/9.0 Sep 13, 2024
9 checks passed
@kunalspathak kunalspathak deleted the backport_107758 branch September 13, 2024 16:48
@kunalspathak kunalspathak added breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet labels Sep 13, 2024
Copy link
Contributor

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet Servicing-approved Approved for servicing release Servicing-consider Issue for next servicing release review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants