-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused freebsd elf32/elf64 header references #107657
Remove unused freebsd elf32/elf64 header references #107657
Conversation
It doesn't make sense to require the freebsd-specific headers on non-FreeBSD platforms. In fact, on my testing, the headers aren't even used. And just break or do the wrong things when system libunwind is used.
5946405
to
4487f7a
Compare
cc @am11 |
It's not really a freebsd specific header - it's just the ELF spec. But that said it doesn't seem like any of the ELF stuff is used by the dwarf writer. So it's ok to remove |
It should be safe to remove. FreeBSD builds currently use their own |
Yup, it's not related to freebsd, it was done as part of the consolidation work omajid@d2264b2, since HP libunwind has ditto headers under freebsd directory.
Just make sure it's not breaking windows builds, since it's under |
Does this meet the bar for backporting to 9.0? Without this change, .NET incorrectly uses the bundled libunwind (or fails to build if the bundled libunwind sources have been deleted as a preventive measure) even on x64 with a command like this:
|
What is the error message and on which platform? This is used by mono-windows as a header only include. It doesn't compile the libunwind. |
In our CI setup, when using system libraries, we rm the bundled libunwind implementation. The leg that builds on x64 with mono fails with:
|
To avoid accidental building? I see this rationale, but isn't it a bit too eager; considering llvm-libunwind in the same You could keep the remote directory and delete the rest: - rm src/native/external/libunwind
+ find src/native/external/libunwind -mindepth 1 ! -regex '^src/native/external/libunwind/include/remote\(/.*\)?' -delete |
Okay, that's fair. Thanks! |
These headers define the ELF structures, but the mono DWARF writer doesn't actually use them for anything. The headers may conflict when system libunwind is used.
These headers define the ELF structures, but the mono DWARF writer doesn't actually use them for anything. The headers may conflict when system libunwind is used.
It doesn't make sense to require the freebsd-specific headers on non-FreeBSD platforms. In fact, on my testing, the headers aren't even used. And just break or do the wrong things when system libunwind is used.