Remove some implicit Helper Method Frames (HMF) #107648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove FCThrow in locations where explicit HMF have been removed. Convert GC.GetGeneration() RuntimeHelpers.EnsureSufficientExecutionStack() RuntimeHelpers.AllocTailCallArgBuffer() Thread.IsBackground getter Thread.IsThreadPoolThread property
|
Tagging subscribers to this area: @mangod9 |
jkotas
reviewed
Sep 11, 2024
| if (objUNSAFE == NULL) | ||
| FCThrowArgumentNull(W("obj")); | ||
|
|
||
| _ASSERTE(objUNSAFE != NULL); | ||
| int result = (INT32)GCHeapUtilities::GetGCHeap()->WhichGeneration(objUNSAFE); | ||
| FC_GC_POLL_RET(); |
There was a problem hiding this comment.
BTW: FC_GC_POLL_RET has a hidden HMF as well (no need to fix in this PR)
...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs
Show resolved
Hide resolved
...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs
Show resolved
Hide resolved
huoyaoyuan
reviewed
Sep 11, 2024
src/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs
Show resolved
Hide resolved
jkotas
reviewed
Sep 23, 2024
jkotas
approved these changes
Sep 23, 2024
jkotas
reviewed
Sep 24, 2024
src/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs
Outdated
Show resolved
Hide resolved
….CoreCLR.cs Co-authored-by: Jan Kotas <[email protected]>
3 tasks
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
* Remove some implicit Helper Method Frames (HMF) Remove FCThrow in locations where explicit HMF have been removed. Convert GC.GetGeneration() RuntimeHelpers.EnsureSufficientExecutionStack() RuntimeHelpers.AllocTailCallArgBuffer() Thread.IsBackground getter Thread.IsThreadPoolThread property --------- Co-authored-by: Jan Kotas <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
FCThrow*in locations where explicit HMF have been removed. Convert the following:GC.GetGeneration()RuntimeHelpers.EnsureSufficientExecutionStack()RuntimeHelpers.AllocTailCallArgBuffer()Thread.IsBackgroundgetterThread.IsThreadPoolThreadproperty