Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify linking file composition for wasi and wasm. #107547

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Sep 9, 2024

Follow up for #107253 (comment).

In browser we don't have single file mode yet, so linking projects with long paths is not a problem. However, maybe we can benefit in the future from the fix we applied to WASI. This PR moves from WASI-only to WASM-targets.

  • Add a test (it was not failing without the fix, it's just to prove we are not breaking anything). It has to test native build, otherwise we don't trigger the linking response file creation (_BrowserWasmWriteRspForLinking).
  • Moves relative path logic from WasiApp.targets to WasmApp.Common.targets.

ToFix:

  • Browser: e.g. Wasm.Build.NativeRebuild.Tests.SimpleSourceChangeRebuildTest.SimpleStringChangeInSource, no idea what's going on
    CompareStat failed: [Expected changed file: rebuild_simple_Release.dll.o]
    = Browser, e.g. Wasm.Build.Tests.BuildPublishTests.BuildThenPublishWithAOT,
Assert.Matches() Failure: Pattern not found in value
      Regex: "build_publish_Release_\\S+.dll.bc -> build_publish"···
      Value: "[]   Determining projects to restore...\n[]   All "···

and many more

@ilonatommy ilonatommy added area-Build-mono os-wasi Related to WASI variant of arch-wasm os-browser Browser variant of arch-wasm labels Sep 9, 2024
@ilonatommy ilonatommy self-assigned this Sep 9, 2024
@pavelsavara pavelsavara added the arch-wasm WebAssembly architecture label Sep 9, 2024
@pavelsavara pavelsavara added this to the 10.0.0 milestone Sep 9, 2024
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm os-wasi Related to WASI variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants