Unify linking file composition for wasi and wasm. #107547
Draft
+44
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #107253 (comment).
In browser we don't have single file mode yet, so linking projects with long paths is not a problem. However, maybe we can benefit in the future from the fix we applied to WASI. This PR moves from WASI-only to WASM-targets.
_BrowserWasmWriteRspForLinking
).WasiApp.targets
toWasmApp.Common.targets
.ToFix:
Wasm.Build.NativeRebuild.Tests.SimpleSourceChangeRebuildTest.SimpleStringChangeInSource
, no idea what's going onCompareStat failed: [Expected changed file: rebuild_simple_Release.dll.o]
= Browser, e.g.
Wasm.Build.Tests.BuildPublishTests.BuildThenPublishWithAOT
,and many more