Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect handle type array/count when FEATURE_SIZED_REF_HANDLES is not defined #107433

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Sep 5, 2024

Fixes #107381

Regression from #107326 - without FEATURE_SIZED_REF_HANDLES defined, this was incorrectly passing an array of two handle types - HNDTYPE_STRONG and HNDTYPE_WEAK_SHORT (0) - when promoting objects pointed to by strong handles.

@elinor-fung elinor-fung merged commit ee1a9ee into dotnet:main Sep 6, 2024
90 checks passed
@elinor-fung elinor-fung deleted the fixHandleTypeCount branch September 6, 2024 02:02
jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 17, 2024
… defined (dotnet#107433)

Regression from dotnet#107326 - without `FEATURE_SIZED_REF_HANDLES` defined, this was incorrectly passing an array of two handle types - HNDTYPE_STRONG and HNDTYPE_WEAK_SHORT (0) - when promoting objects pointed to by strong handles.
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
… defined (dotnet#107433)

Regression from dotnet#107326 - without `FEATURE_SIZED_REF_HANDLES` defined, this was incorrectly passing an array of two handle types - HNDTYPE_STRONG and HNDTYPE_WEAK_SHORT (0) - when promoting objects pointed to by strong handles.
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants