Skip to content

Conversation

carlossanlop
Copy link
Contributor

Contributes to #101465

General guidance with the essential steps to add or update a native external library.

Each library might have its own specific steps, we can add them later as needed.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@carlossanlop carlossanlop mentioned this pull request Jul 17, 2024
18 tasks
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have some guidance somewhere about when to vendor in a library vs depend on a system library (ie explaining why we vendor in zlib-ng but don't vendor in openssl).

@carlossanlop
Copy link
Contributor Author

We should have some guidance somewhere about when to vendor in a library vs depend on a system library (ie explaining why we vendor in zlib-ng but don't vendor in openssl).

Good point. Let me think about this.

@carlossanlop
Copy link
Contributor Author

Sorry for the delay here. I have addressed the last batch of comments.

Copy link
Contributor

@blowdart blowdart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including the cg pieces, that's the most important bit

@carlossanlop carlossanlop merged commit e2eb8c4 into dotnet:main Feb 25, 2025
15 checks passed
@carlossanlop carlossanlop deleted the NativeUpdateInstructions branch February 25, 2025 21:00
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants