Check for IDispatch properly
#104406
Merged
Check for IDispatch properly
#104406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of simply casting to IDispatch, we now QI on managed types. This was uncovered in an out-of-proc COM scenario.
This was referenced Jul 4, 2024
Open
elinor-fung
approved these changes
Jul 8, 2024
Co-authored-by: Elinor Fung <[email protected]>
matouskozak
added a commit
to matouskozak/runtime
that referenced
this pull request
Jul 11, 2024
This reverts commit 0dd2a62.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of simply casting to
IDispatch*, we now QI on managed types. This was uncovered in an out-of-proc COM scenario.This introduces a subtle code change that now generates an error in CoreCLR.
The above API will fail since it assumes the target type has a default constructor. The
TargetInvocationExceptiondoesn't have one and instead of this propogating back up to managed it would result in aMissingMethodExceptionfor.ctor, which is very confusing. This PR changes all uses of the above to instead throw akTargetException, which is technically different from .NET Framework, but since no one would have seen theTargetInvocationExceptionbehavior it seems like a harmless change.