Fix potential Debug.Assert in QuicListener #103965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/ncl |
ManickaP
approved these changes
Jun 25, 2024
|
can we craft test that would cause the timeout predictably? |
we have a test for timeouts, but this the failure happened because the timeout ran out at the same time we got connection shutdown notification from MsQuic so it was effectively a data race. I don't see a way to craft a test for this (I tested this by adding extra waits and other changes to trigger the exact failure condition). |
|
/ba-g failures are either known or unrelated (wasm library build errors) |
rzikm
added a commit
that referenced
this pull request
Jun 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103911.
The reason the crash happened is that both
linkedCtsandconnection.ConnectionShutdownTokenfired. The code checkedConnectionShutdownTokenfirst, assuming that the connection close because peer closed it during the handshake, but the reason for the exception was actually because theHandshakeTimeoutran out, so the control flow shouldn't have entered that catch block in the first place.Checking that
linkedCtshas not been signalled yet eliminates the race.