-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Have COND_JUMP handling check for gtEffectiveVal #103649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
689e7c8
Adding a regression test
tannergooding e9d618a
Have COND_JUMP handling check for gtEffectiveVal
tannergooding 11a282b
Ensure we don't drop a side effect
tannergooding 228272e
Ensure we test for the side effect
tannergooding 50a4a74
Merge remote-tracking branch 'dotnet/main' into fix-103600
tannergooding File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
src/tests/JIT/Regression/JitBlue/Runtime_103600/Runtime_103600.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System; | ||
| using System.Runtime.CompilerServices; | ||
| using Xunit; | ||
|
|
||
| // Generated by Fuzzlyn v1.6 on 2024-06-16 15:10:23 | ||
| // Run on X64 Windows | ||
| // Seed: 6886681321438315426 | ||
| // Reduced from 30.1 KiB to 0.3 KiB in 00:01:11 | ||
| // Hits JIT assert in Release: | ||
| // Assertion failed 'cond == test->AsOp()->gtOp1' in 'Program:Main(Fuzzlyn.ExecutionServer.IRuntime)' during 'Update flow graph early pass' (IL size 27; hash 0xade6b36b; FullOpts) | ||
| // | ||
| // File: D:\a\_work\1\s\src\coreclr\jit\fgopt.cpp Line: 5447 | ||
| // | ||
| public class Runtime_103600 | ||
| { | ||
| [Fact] | ||
| public static int TestEntryPoint() | ||
| { | ||
| int result = 0; | ||
|
|
||
| try | ||
| { | ||
| Test(); | ||
| } | ||
| catch (NullReferenceException) | ||
| { | ||
| result = 100; | ||
| } | ||
|
|
||
| return result; | ||
| } | ||
|
|
||
| [MethodImpl(MethodImplOptions.NoInlining)] | ||
| private static void Test() | ||
| { | ||
| ulong[] vr0 = default(ulong[]); | ||
|
|
||
| if (0 > vr0[0]) | ||
| { | ||
| vr0 = vr0; | ||
| } | ||
| else | ||
| { | ||
| vr0 = new ulong[]{0}; | ||
| } | ||
|
|
||
| vr0[0] = vr0[0]; | ||
| } | ||
| } |
8 changes: 8 additions & 0 deletions
8
src/tests/JIT/Regression/JitBlue/Runtime_103600/Runtime_103600.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <Optimize>True</Optimize> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <Compile Include="$(MSBuildProjectName).cs" /> | ||
| </ItemGroup> | ||
| </Project> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.