Skip to content

Move downlevel tests to outerloop #103595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Move downlevel tests to outerloop #103595

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d028f5
Move downlevel tests to outerloop
jkoritzinsky Jun 17, 2024
99ffb20
Remove MemberData method that is now unused
jkoritzinsky Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions ...braries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/Compiles.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,22 +707,35 @@ private static string RemoveTestMarkup(string sourceWithMarkup)
return sourceWithoutMarkup;
}

public static IEnumerable<object[]> CodeSnippetsToVerifyNoTreesProduced()
[Fact]
public async Task ValidateNoGeneratedOutputForNoImport()
{
string source = """
using System.Runtime.InteropServices;
public class Basic { }
""";
yield return new object[] { ID(), source, TestTargetFramework.Standard };
yield return new object[] { ID(), source, TestTargetFramework.Framework };
yield return new object[] { ID(), source, TestTargetFramework.Net };

var test = new NoChangeTest(TestTargetFramework.Net)
{
TestCode = source,
TestBehaviors = TestBehaviors.SkipGeneratedSourcesCheck
};

await test.RunAsync();
}


[OuterLoop("Uses the network for downlevel ref packs")]
[InlineData(TestTargetFramework.Standard)]
[InlineData(TestTargetFramework.Framework)]
[Theory]
[MemberData(nameof(CodeSnippetsToVerifyNoTreesProduced))]
public async Task ValidateNoGeneratedOutputForNoImport(string id, string source, TestTargetFramework framework)
public async Task ValidateNoGeneratedOutputForNoImportDownlevel(TestTargetFramework framework)
{
TestUtils.Use(id);
string source = """
using System.Runtime.InteropServices;
public class Basic { }
""";

var test = new NoChangeTest(framework)
{
TestCode = source,
Expand Down