Add ILLink option to preserve symbol paths #103295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-Tools-ILLink
dotnet-policy-service
bot
added
the
linkable-framework
sbomer
changed the title
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas |
Otherwise writing a module will try to use the symbol writer provider, but the underlying DefaultSymbolWriterProvider throws when the module has no symbol reader (this is the case when there were no symbols corresponding to the module).
This was referenced Jun 12, 2024
Open
jtschuster
approved these changes
Jun 14, 2024
This was referenced Jun 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds ILLink support for
--preserve-symbol-paths, which is set whenDeterministicSourcePathsis true.This setting will preserve the original pdb path from the inputs by using a custom symbol writer (see dotnet/cecil#183 (comment)).
Confirmed that this fixes #99594. No tests here because I think the best way to test this is either via a checked-in binary (which needs more infrastructure, mentioned in #78344) or a testcase that uses the SDK to build a test assembly with DeterministicSourcePaths. For now I plan to add a test in dotnet/sdk once this change flows.