Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back JIT support for core Vector64/128/256/512 APIs #103177

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

tannergooding
Copy link
Member

@tannergooding tannergooding commented Jun 7, 2024

As per the discussion in #103150, the basic building blocks (Vector64/128/256/512<T> and Vector<T>) should stay intrinsic in the JIT.

This doesn't bring back "all" APIs, but rather the core ones that are expected to see the heaviest usage. In general, the rule I followed on deciding what to bring back vs not was that if it was a general API that was a 1-to-1 forward to another intrinsic and didn't get any other specialization it was fine to leave in managed

So while it brings back ones like get_Zero and As, it doesn't bring back And (forwards to op_BitwiseAddition), Add (forwards to op_Addition), or Load (forwards to LoadUnsafe).

As per the discussion, Vector2, Vector3, Vector4, Quaternion, and Plane remain implemented in managed.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 7, 2024
@tannergooding
Copy link
Member Author

CC. @jkotas

Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (Somebody from the JIT team should signoff as well.)

@tannergooding
Copy link
Member Author

(Pushed to the wrong branch by accident, it's back to how it was at last approval)

@tannergooding
Copy link
Member Author

(Somebody from the JIT team should signoff as well.)

CC. @EgorBo, since you've reviewed the other PRs

@tannergooding tannergooding merged commit 4078743 into dotnet:main Jun 12, 2024
171 of 173 checks passed
@tannergooding tannergooding deleted the proto-102275 branch June 12, 2024 06:40
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants