Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpIOException when establishing connection, unobserved task exception #102960

Merged
merged 3 commits into from
Jun 13, 2024
Merged

HttpIOException when establishing connection, unobserved task exception #102960

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9b25eb
HttpIOException when establishing connection, unobserved task exception
pedrobsaila Jun 1, 2024
3ce1648
do not eagerly allocate InitialSettingsReceived
pedrobsaila Jun 2, 2024
9a3de10
Update src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpH…
MihaZupan Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Connection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ public async ValueTask SetupAsync(CancellationToken cancellationToken)
// Processing the incoming frames before sending the client preface and SETTINGS is necessary when using a NamedPipe as a transport.
// If the preface and SETTINGS coming from the server are not read first the below WriteAsync and the ProcessIncomingFramesAsync fall into a deadlock.
_ = ProcessIncomingFramesAsync();
LogExceptions(InitialSettingsReceived.Task);
MihaZupan marked this conversation as resolved.
Show resolved Hide resolved
await _stream.WriteAsync(_outgoingBuffer.ActiveMemory, cancellationToken).ConfigureAwait(false);
_rttEstimator.OnInitialSettingsSent();
_outgoingBuffer.ClearAndReturnBuffer();
Expand Down
Loading