Skip to content

Conversation

@hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented May 24, 2024

main PR #102639

Description

Update to DIA to version shipped in MSVC equivalent of dev17.10.

Customer Impact

Code cleanliness - DIA has had several CVEs fixed. While the .NET runtime doesn't use any of the vulnerable APIs, detection software might flag the dll. This helps our customers maintain clean reports

Regression

No

Testing

Manual validation of basic scenarios.

Risk

Low - limited runtime scenarios use this and targeted fixes to the library shouldn't affect us

@hoyosjs hoyosjs requested a review from a team May 24, 2024 02:29
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 24, 2024
@hoyosjs hoyosjs changed the title Update DIA to 17.10.0-beta1.24272.1 [release/6.0] Update DIA to 17.10.0-beta1.24272.1 May 24, 2024
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. we will take for consideration in 6.0.x

@jeffschwMSFT jeffschwMSFT added the Servicing-consider Issue for next servicing release review label May 24, 2024
@jeffschwMSFT jeffschwMSFT added this to the 6.0.x milestone May 24, 2024
@jeffschwMSFT jeffschwMSFT added area-Diagnostics-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 24, 2024
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels May 31, 2024
@jeffschwMSFT jeffschwMSFT modified the milestones: 6.0.x, 6.0.31 May 31, 2024
@hoyosjs hoyosjs merged commit ec9de44 into release/6.0-staging May 31, 2024
@hoyosjs hoyosjs deleted the hoyosjs-patch-2 branch May 31, 2024 18:03
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants