Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LoongArch64] Synchronize with PR#102469. #102638

Merged
merged 1 commit into from
May 24, 2024

Conversation

LuckyXu-HF
Copy link
Contributor

@LuckyXu-HF LuckyXu-HF commented May 24, 2024

[LoongArch64] Synchronize with PR#102469.

  • And fix the build error for LoongArch64.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 24, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 24, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@LuckyXu-HF
Copy link
Contributor Author

Besides,the following build error under debug mode on LA64 after #102297 is fixed by #102631 .

...
[ 97%] Built target clrjit_static
Consolidate compiler generated dependencies of target coreclr_static
[ 97%] Linking CXX static library libcoreclr_static.a
[ 97%] Built target coreclr_static
Consolidate compiler generated dependencies of target singlefilehost
[ 97%] Linking CXX executable singlefilehost
ld.lld: error: undefined symbol: RegSet::rsAllCalleeSavedMask
>>> referenced by regset.h:95 (/data_loongson/xuliangyu/dotnet-runtime-loongarch/src/coreclr/jit/regset.h:95)
>>>               codegencommon.cpp.o:(RegSet::rsGetModifiedCalleeSavedRegsMask() const) in archive ../dlls/mscoree/coreclr/libcoreclr_static.a
>>> referenced by regset.h:95 (/data_loongson/xuliangyu/dotnet-runtime-loongarch/src/coreclr/jit/regset.h:95)
>>>               codegencommon.cpp.o:(RegSet::rsGetModifiedCalleeSavedRegsMask() const) in archive ../dlls/mscoree/coreclr/libcoreclr_static.a
>>> referenced by regset.h:95 (/data_loongson/xuliangyu/dotnet-runtime-loongarch/src/coreclr/jit/regset.h:95)
>>>               codegencommon.cpp.o:(RegSet::rsGetModifiedCalleeSavedRegsMask() const) in archive ../dlls/mscoree/coreclr/libcoreclr_static.a
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [Corehost.Static/CMakeFiles/singlefilehost.dir/build.make:1384:Corehost.Static/singlefilehost] 错误 1
make[1]: *** [CMakeFiles/Makefile2:1917:Corehost.Static/CMakeFiles/singlefilehost.dir/all] 错误 2
make: *** [Makefile:136:all] 错误 2
/data_loongson/xuliangyu/dotnet-runtime-loongarch
Failed to build "CoreCLR component".

Copy link
Contributor

@shushanhf shushanhf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks

@LuckyXu-HF
Copy link
Contributor Author

Hi @kunalspathak @jakobbotsch , could you please review this PR? Thanks.

Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunalspathak kunalspathak merged commit bbcde65 into dotnet:main May 24, 2024
107 checks passed
@LuckyXu-HF LuckyXu-HF deleted the main-LA64 branch May 27, 2024 09:00
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-loongarch64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants