-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LoongArch64] Synchronize with PR#102469. #102638
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Besides,the following build error under debug mode on LA64 after #102297 is fixed by #102631 . ...
[ 97%] Built target clrjit_static
Consolidate compiler generated dependencies of target coreclr_static
[ 97%] Linking CXX static library libcoreclr_static.a
[ 97%] Built target coreclr_static
Consolidate compiler generated dependencies of target singlefilehost
[ 97%] Linking CXX executable singlefilehost
ld.lld: error: undefined symbol: RegSet::rsAllCalleeSavedMask
>>> referenced by regset.h:95 (/data_loongson/xuliangyu/dotnet-runtime-loongarch/src/coreclr/jit/regset.h:95)
>>> codegencommon.cpp.o:(RegSet::rsGetModifiedCalleeSavedRegsMask() const) in archive ../dlls/mscoree/coreclr/libcoreclr_static.a
>>> referenced by regset.h:95 (/data_loongson/xuliangyu/dotnet-runtime-loongarch/src/coreclr/jit/regset.h:95)
>>> codegencommon.cpp.o:(RegSet::rsGetModifiedCalleeSavedRegsMask() const) in archive ../dlls/mscoree/coreclr/libcoreclr_static.a
>>> referenced by regset.h:95 (/data_loongson/xuliangyu/dotnet-runtime-loongarch/src/coreclr/jit/regset.h:95)
>>> codegencommon.cpp.o:(RegSet::rsGetModifiedCalleeSavedRegsMask() const) in archive ../dlls/mscoree/coreclr/libcoreclr_static.a
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [Corehost.Static/CMakeFiles/singlefilehost.dir/build.make:1384:Corehost.Static/singlefilehost] 错误 1
make[1]: *** [CMakeFiles/Makefile2:1917:Corehost.Static/CMakeFiles/singlefilehost.dir/all] 错误 2
make: *** [Makefile:136:all] 错误 2
/data_loongson/xuliangyu/dotnet-runtime-loongarch
Failed to build "CoreCLR component". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks
Hi @kunalspathak @jakobbotsch , could you please review this PR? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LoongArch64] Synchronize with PR#102469.