Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the corehost CMake system to be more "Modern CMake"y and less MSBuild-y #102475

Merged
merged 18 commits into from
Jun 5, 2024

Conversation

jkoritzinsky
Copy link
Member

  • Use configure_file instead of stringly-defined macros.
  • Flow include directories through CMake target definitions.
  • Use functions instead of include(foo.cmake)

This moves our CMake for the hosts build to be more similar to the rest of the build and more similar to CMake documentation you'll find online. This also removes quite a bit of duplicate/unnecessary CMake for some targets that was applied more widely than necessary.

Copy link
Contributor

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

@jkoritzinsky jkoritzinsky marked this pull request as ready for review May 22, 2024 00:09
src/native/corehost/nethost/CMakeLists.txt Show resolved Hide resolved
src/native/corehost/corehost.cpp Outdated Show resolved Hide resolved
src/native/corehost/CMakeLists.txt Show resolved Hide resolved
src/native/corehost/CMakeLists.txt Outdated Show resolved Hide resolved
src/native/corehost/CMakeLists.txt Outdated Show resolved Hide resolved
src/native/corehost/hostmisc/CMakeLists.txt Outdated Show resolved Hide resolved
src/coreclr/CMakeLists.txt Outdated Show resolved Hide resolved
src/native/corehost/fxr/standalone/CMakeLists.txt Outdated Show resolved Hide resolved
src/native/corehost/test/fx_ver/CMakeLists.txt Outdated Show resolved Hide resolved
src/native/corehost/apphost/standalone/CMakeLists.txt Outdated Show resolved Hide resolved
src/native/corehost/CMakeLists.txt Outdated Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants