Backport #92296 and #92438 to release/6.0-staging #101822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
amanasifkhalid
added
area-Infrastructure
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
amanasifkhalid
force-pushed
the
release/6.0-staging
branch
from
964d141 to
0d5c19b
Compare
Contributor
Author
|
/azp run runtime |
|
Azure Pipelines failed to run 1 pipeline(s). |
3 tasks
This was referenced May 4, 2024
Closed
amanasifkhalid
changed the title
Contributor
Author
|
Failures in public CI are known |
Contributor
Author
|
ping @agocke (sorry, I didn't realize Jeremy is out of office at the moment) |
agocke
approved these changes
May 13, 2024
Member
agocke
left a comment
agocke
left a comment
There was a problem hiding this comment.
LGTM. FYI, if the PGO build is broken, we probably won't find the issue until it flows up the stack. There's nothing to do about that, it's just the way it works.
Contributor
Author
|
Thank you!
I see, I'll keep this in mind. |
jeffschwMSFT
approved these changes
May 13, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we can treat this as tell mode, merge when ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of multiple PRs to replicate @eduardo-vp's work of merging commits needed to transition the
release/6.0-stagingbranch to 1ES pipeline templates. Because this branch andmainhave diverged quite a bit, I found it safer to manually merge each change by hand, rather than relying ongit cherry-pick. As such, this PR probably warrants extra scrutiny...Official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2448493&view=results
cc @agocke @jkoritzinsky