Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IsOSPlatform instead of checking for /proc #101547

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Use IsOSPlatform instead of checking for /proc #101547

merged 2 commits into from
Jun 4, 2024

Conversation

am11
Copy link
Member

@am11 am11 commented Apr 25, 2024

as IsOSPlatform(OSPlatform.Windows) is already used in a few places under illink dir.

@am11 am11 requested a review from marek-safar as a code owner April 25, 2024 13:49
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Apr 25, 2024
@dotnet-policy-service dotnet-policy-service bot added linkable-framework Issues associated with delivering a linker friendly framework community-contribution Indicates that the PR has been added by a community member labels Apr 25, 2024
@huoyaoyuan
Copy link
Member

Since NetCoreAppToolCurrent is recent, can OperatingSystem.IsXXX be used instead?

@am11
Copy link
Member Author

am11 commented Apr 25, 2024

Since NetCoreAppToolCurrent is recent, can OperatingSystem.IsXXX be used instead?

I saw linker and some of its tests are building for netstandard2 / NetFrameworkToolCurrent, so I used IsOSPlatform which is used in other places in linker code.

(btw: its codegen has improved since .NET 8 #83308)

This was referenced Apr 25, 2024
Closed
Closed
Closed
Closed
@jkotas jkotas closed this Jun 3, 2024
@jkotas jkotas reopened this Jun 3, 2024
This was referenced Jun 3, 2024
Closed
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Jun 4, 2024
Closed
@jkotas jkotas merged commit 7803a96 into dotnet:main Jun 4, 2024
74 of 76 checks passed
@am11 am11 deleted the patch-31 branch June 14, 2024 04:38
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbomer sbomer sbomer approved these changes

@agocke agocke agocke approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

Assignees
No one assigned
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers community-contribution Indicates that the PR has been added by a community member linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@am11 @huoyaoyuan @agocke @sbomer @jkotas