Disable System.Text.Json.Tests suite on interp with debug runtime #101483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interpreter gets very slow on debug builds and this suite can also timeout.
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
BrzVlad
commented
Apr 24, 2024
| using System; | ||
| using Xunit; | ||
|
|
||
| [assembly: ActiveIssue("Interpreter with debug runtime can be very slow", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoInterpreter), nameof(PlatformDetection.IsDebugRuntime))] |
There was a problem hiding this comment.
@akoeplinger Not sure if we have a better flag here. I think having a tracking issue is redundant since it is not something worth addressing in my opinion.
There was a problem hiding this comment.
Yeah I checked and we don't have a better way right now since all of the Conditional* attributes can't be applied to assembly. I'm fine with this.
akoeplinger
approved these changes
Apr 24, 2024
| using System; | ||
| using Xunit; | ||
|
|
||
| [assembly: ActiveIssue("Interpreter with debug runtime can be very slow", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoInterpreter), nameof(PlatformDetection.IsDebugRuntime))] |
There was a problem hiding this comment.
Yeah I checked and we don't have a better way right now since all of the Conditional* attributes can't be applied to assembly. I'm fine with this.
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
…tnet#101483) Interpreter gets very slow on debug builds and this suite can also timeout.
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
…tnet#101483) Interpreter gets very slow on debug builds and this suite can also timeout.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interpreter gets very slow on debug builds and this suite can also timeout.