Remove direct package references on System.Collections.Immutable and System.Reflection.Metadata #101386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-merge-8.0-2024-04-09-1217
…8.0-2024-04-09-1217 Merging internal commits for release/8.0
…Number.BigInteger Resolve MSRC 68613 for .NET 8
…Type Fix unbound MAC work in GetCertContentType
[manual] Merge release/8.0-staging into release/8.0
…otnet#101145) * Update MicrosoftBuildVersion to latest to fix System.Security.Cryptography.XML component governance alert. * Add info to VersionDetails to allow sourcebuild to update the MSBuild dependency * Update SourceBuildPrebuiltBaseline.xml --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Parker Bibus <[email protected]> Co-authored-by: Eric StJohn <[email protected]> Co-authored-by: Michael Simons <[email protected]>
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
jkotas
reviewed
Apr 22, 2024
|
Closing in favor of a new PR. |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to: dotnet/source-build#4344
With #100595, source-build got broken in release/8.0.1xx, due to package downgrade issue. Source-build consumes MSBuild 17.8.5, while runtime is on 17.8.3. Source-build will update MSBuild package references to live ones (17.8.5), but two runtime projects had direct package references, on S.C.I and S.R.M which caused package downgrade warning (prompted to error in source-build).
The fix is to remove these direct package references as they will be transitively resolved from MSBuild package reference. This will allow both source-build and repo build to get the correct sets of references.