Keep our System.Text.Json version used in HostModel in sync with MSBuild #101199
Conversation
…ild. This follows the same pattern as Roslyn, and ensures that the binding redirects in MSBuild kick in on .NET Framework. This also happens to help unblock dotnet/installer#19491 by working around the downgrade problem.
|
Tagging subscribers to this area: @vitek-karas, @agocke |
| <SystemReflectionMetadataLoadContextToolsetVersion Condition="'$(DotNetBuildSourceOnly)' == 'true'">$(SystemReflectionMetadataLoadContextVersion)</SystemReflectionMetadataLoadContextToolsetVersion> | ||
| <SystemTextJsonToolsetVersion Condition="'$(DotNetBuildSourceOnly)' == 'true'">$(SystemTextJsonVersion)</SystemTextJsonToolsetVersion> |
There was a problem hiding this comment.
should we override SystemCollectionsImmutableToolsetVersion and SystemReflectionMetadataToolsetVersion too?
There was a problem hiding this comment.
We have source-build-reference-packages for them for the versions we use, so it's not necessary. We could for consistency.
There was a problem hiding this comment.
Note that SBRP can only be used when the assembly in question doesn't get loaded which isn't true for build tasks.
There was a problem hiding this comment.
MSBuild loads these ones in this case (that's why we're trying to version-match)
There was a problem hiding this comment.
I think I'd prefer the consistency
This follows the same pattern as Roslyn, and ensures that the binding redirects in MSBuild kick in on .NET Framework.
This also happens to help unblock dotnet/installer#19491 by working around the downgrade problem.