Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] install Firefox on helix #101171

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Apr 17, 2024

Separated from #100697 for ease of review

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Apr 17, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Apr 17, 2024
@pavelsavara pavelsavara self-assigned this Apr 17, 2024
@pavelsavara pavelsavara marked this pull request as ready for review April 17, 2024 11:03
@pavelsavara
Copy link
Member Author

/ba-g CI failures are #98578 and #100910

Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename the file for BrowserVersions.props?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next PR

@pavelsavara pavelsavara merged commit a933518 into dotnet:main Apr 17, 2024
35 of 41 checks passed
@pavelsavara pavelsavara deleted the firefox_install branch April 17, 2024 12:05
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants