-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix more diagnostics with CA2263 #100490
Fix more diagnostics with CA2263 #100490
Conversation
Tagging subscribers to this area: @dotnet/area-meta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a lot of interop cleanup and simplification that can be done in the legacy components. I have commented on some of it (it may require annotating method as unsafe
).
...pendencyInjection.Abstractions/src/Extensions/ServiceCollectionDescriptorExtensions.Keyed.cs
Outdated
Show resolved
Hide resolved
...ibraries/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/ComInterop/ComRuntimeHelpers.cs
Outdated
Show resolved
Hide resolved
...ibraries/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/ComInterop/ComRuntimeHelpers.cs
Outdated
Show resolved
Hide resolved
...braries/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/ComInterop/IDispatchComObject.cs
Outdated
Show resolved
Hide resolved
...ctoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/AD/SidList.cs
Outdated
Show resolved
Hide resolved
...rectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/AuthZSet.cs
Outdated
Show resolved
Hide resolved
...rectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/AuthZSet.cs
Outdated
Show resolved
Hide resolved
....DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/Utils.cs
Outdated
Show resolved
Hide resolved
....DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/Utils.cs
Outdated
Show resolved
Hide resolved
....DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/Utils.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Fix more diagnostics with CA2263 * Apply feedbacks
* Fix more diagnostics with CA2263 * Apply feedbacks
Fix more diagnostics found with
CA2263: Prefer generic overload when type is known
Excluded fixing diagnostics for
netstandard
Microsoft.Extensions.DependencyInjection.Specification.Tests
Linq.Expressions
Related to #99343 (comment)