Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][MT] assert no managed transition on UI thread after start #100410

Merged
merged 8 commits into from
Apr 3, 2024
Merged

[browser][MT] assert no managed transition on UI thread after start #100410

merged 8 commits into from
Apr 3, 2024

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Mar 28, 2024 •
edited
Loading

make sure we don't overstep GC boundaries on the UI thread
There are exceptions for Blazor described in #100411

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Mar 28, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Mar 28, 2024
@pavelsavara pavelsavara self-assigned this Mar 28, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@pavelsavara pavelsavara requested review from kg and maraf March 28, 2024 16:16
This was referenced Mar 28, 2024
Closed
Closed
@pavelsavara pavelsavara changed the title [browser][MT] disableManagedTransition on UI thread after start [browser][MT] reduce managed transition on UI thread after start Apr 2, 2024
This was referenced Apr 2, 2024
Closed
Closed
Closed
@pavelsavara pavelsavara marked this pull request as ready for review April 3, 2024 07:53
@pavelsavara pavelsavara requested a review from lewing as a code owner April 3, 2024 07:53
@pavelsavara
Copy link
Member Author

CI failures are #99888

@pavelsavara pavelsavara changed the title [browser][MT] reduce managed transition on UI thread after start [browser][MT] assert no managed transition on UI thread after start Apr 3, 2024
maraf
maraf approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

src/mono/browser/runtime/roots.ts Outdated Show resolved Hide resolved
src/mono/browser/runtime/roots.ts Outdated Show resolved Hide resolved
@build-analysis build-analysis bot mentioned this pull request Apr 3, 2024
Closed
@pavelsavara pavelsavara merged commit d0023cf into dotnet:main Apr 3, 2024
33 of 36 checks passed
@pavelsavara pavelsavara deleted the browser_mt_asserts branch April 3, 2024 13:44
@build-analysis build-analysis bot mentioned this pull request Apr 3, 2024
Closed
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@pavelsavara @maraf @matouskozak
[browser][MT] assert no managed transition on UI thread after start (d…
35aff5d 
…otnet#100410)

Co-authored-by: Marek Fišera <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kg kg kg left review comments

@maraf maraf maraf approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelsavara @kg @maraf