Cleanup NativeAOT math helpers #100375
Merged
Cleanup NativeAOT math helpers #100375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
jkotas
reviewed
Mar 29, 2024
...coreclr/nativeaot/System.Private.CoreLib/src/Internal/Runtime/CompilerHelpers/MathHelpers.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Mar 29, 2024
...coreclr/nativeaot/System.Private.CoreLib/src/Internal/Runtime/CompilerHelpers/MathHelpers.cs
Outdated
Show resolved
Hide resolved
3 tasks
jkotas
reviewed
Mar 30, 2024
...coreclr/nativeaot/System.Private.CoreLib/src/Internal/Runtime/CompilerHelpers/MathHelpers.cs
Outdated
Show resolved
Hide resolved
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
...coreclr/nativeaot/System.Private.CoreLib/src/Internal/Runtime/CompilerHelpers/MathHelpers.cs
Outdated
Show resolved
Hide resolved
tannergooding
approved these changes
Apr 1, 2024
jkotas
reviewed
Apr 1, 2024
...coreclr/nativeaot/System.Private.CoreLib/src/Internal/Runtime/CompilerHelpers/MathHelpers.cs
Outdated
Show resolved
Hide resolved
|
The outer loop failures look unrelated. |
MichalPetryka
commented
Apr 5, 2024
Comment on lines
+53
to
+54
| // We need to compare with the very next double to two63. 0x402 is epsilon to get us there. | ||
| if (value is > -two63 - 0x402 and < two63) |
There was a problem hiding this comment.
Suggested change
| // We need to compare with the very next double to two63. 0x402 is epsilon to get us there. | |
| if (value is > -two63 - 0x402 and < two63) | |
| if (value is > Math.BitDecrement(-two63) and < two63) |
Would this work here?
There was a problem hiding this comment.
Not a compile-time constant
There was a problem hiding this comment.
Would this work here?
Nope. BitDecrement is not a JIT intrinsic, and it is too complicated to make the JIT inline in and evaluate it into a constant.
jkotas
reviewed
Apr 5, 2024
...coreclr/nativeaot/System.Private.CoreLib/src/Internal/Runtime/CompilerHelpers/MathHelpers.cs
Outdated
Show resolved
Hide resolved
…ime/CompilerHelpers/MathHelpers.cs
|
Thank you! |
MichalStrehovsky
added a commit
to MichalStrehovsky/runtime
that referenced
this pull request
Apr 9, 2024
dotnet#100375 broke optimized Windows x86 runs.
MichalStrehovsky
added a commit
that referenced
this pull request
Apr 9, 2024
#100375 broke optimized Windows x86 runs.
Merged
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
* Cleanup NativeAOT math helpers * Restore checked cast helpers * Rename variables --------- Co-authored-by: Jan Kotas <[email protected]>
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
dotnet#100375 broke optimized Windows x86 runs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #98858.
cc @jkotas I'd like the cleanup here to be merged here before moving the Checked multiply helpers around.