Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][MT] mono_wasm_schedule_synchronization_context #100251

Merged
merged 14 commits into from
Apr 3, 2024
Merged

[browser][MT] mono_wasm_schedule_synchronization_context #100251

merged 14 commits into from
Apr 3, 2024

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Mar 25, 2024 •
edited
Loading

In MT

  • use simpler mono_wasm_schedule_synchronization_context instead of schedule_background_exec
  • schedules mono_wasm_synchronization_context_pump
  • drop mono_current_thread_schedule_background_job
  • drop jobs_key TLS

In ST

  • make scheduling.ts ST only and simplified
  • simpler mono_background_exec

@pavelsavara
use simpler mono_wasm_schedule_synchronization_context instead of `…
3f030a1 
…schedule_background_exec`

makes scheduling.ts ST only
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Mar 25, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Mar 25, 2024
@pavelsavara pavelsavara requested review from kg and maraf March 25, 2024 19:51
@pavelsavara pavelsavara self-assigned this Mar 25, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

This was referenced Mar 25, 2024
Open
Open
Closed
Closed
This was referenced Mar 27, 2024
Closed
Closed
@pavelsavara pavelsavara reopened this Mar 27, 2024
@pavelsavara
Merge branch 'main' into browser_mt_sync_context_pump
409b922 
# Conflicts:
#	src/mono/browser/runtime/pthreads/shared.ts
#	src/mono/browser/runtime/scheduling.ts
@pavelsavara
more
326c29a
@pavelsavara pavelsavara marked this pull request as ready for review March 27, 2024 17:57
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Mar 28, 2024
Closed
Open
@pavelsavara
Copy link
Member Author

submitted #100409

This was referenced Apr 2, 2024
Closed
Closed
Closed
Closed
@pavelsavara
Copy link
Member Author

/ba-g timeouts are known #99888 and #100445

@build-analysis build-analysis bot mentioned this pull request Apr 2, 2024
Open
@pavelsavara pavelsavara merged commit 3bae822 into dotnet:main Apr 3, 2024
118 of 121 checks passed
@pavelsavara pavelsavara deleted the browser_mt_sync_context_pump branch April 3, 2024 08:10
@build-analysis build-analysis bot mentioned this pull request Apr 3, 2024
Closed
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@pavelsavara @matouskozak
[browser][MT] mono_wasm_schedule_synchronization_context (dotnet#100251)
449b8db
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf approved these changes

@kg kg Awaiting requested review from kg

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@lambdageek lambdageek Awaiting requested review from lambdageek lambdageek is a code owner

@steveisok steveisok Awaiting requested review from steveisok steveisok is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelsavara @maraf