Skip to content

Fix calculation in PREPARE_EXTERNAL_VAR[_INDIRECT] #100117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2024
Merged

Fix calculation in PREPARE_EXTERNAL_VAR[_INDIRECT] #100117

merged 2 commits into from
Mar 22, 2024

Conversation

filipnavara
Copy link
Member

Fixes #100112

@filipnavara filipnavara requested a review from jkotas March 22, 2024 03:58
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 22, 2024
@filipnavara
Copy link
Member Author

Please run /azp run runtime-nativeaot-outerloop.

This is a bug that I already fixed on few other places earlier. The PC relative calculation must be relative to the actual instruction, which is -12 for movw and -8 for movt in this pattern. If the symbol is aligned just right, we would end up with the correct bottom half but off-by-one top half.

@jkotas
Copy link
Member

jkotas commented Mar 22, 2024

/azp run runtime-nativeaot-outerloop

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@filipnavara filipnavara marked this pull request as ready for review March 22, 2024 04:36
jkotas
jkotas approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

This was referenced Mar 22, 2024
Closed
Closed
@MichalStrehovsky
Copy link
Member

/azp run runtime-nativeaot-outerloop

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky MichalStrehovsky mentioned this pull request Mar 22, 2024
Closed
@filipnavara
Copy link
Member Author

The build failures are unrelated.

@jkotas jkotas merged commit 3cf7759 into dotnet:main Mar 22, 2024
@filipnavara filipnavara deleted the PREPARE_EXTERNAL_VAR_INDIRECT branch March 22, 2024 14:12
@build-analysis build-analysis bot mentioned this pull request Mar 22, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotas jkotas jkotas approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

No one assigned

Labels

arch-arm32 area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[NativeAOT/arm32] Crash in write barrier early during startup

3 participants

@filipnavara @jkotas @MichalStrehovsky