Remove various single-scenario YAML parameters in our build scripts and shift implementation responsibility to those scenarios #100115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd shift implementation responsibility to those scenarios. Uses Arcade defaults to remove richCodeNavigation property. Inline CodeQL injection to the CodeQL pipeline Use Arcade's Source-Build jobs now that we aren't using any features that require the steps support.
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
This was referenced Mar 22, 2024
This was referenced Apr 2, 2024
This was referenced Apr 8, 2024
hoyosjs
approved these changes
Apr 12, 2024
| parameters: | ||
| platforms: | ||
| - name: CentOS8 | ||
| targetRid: centos.8-x64 |
There was a problem hiding this comment.
Yes, but I wanted to preserve existing behavior in this PR to limit possible issues.
| @@ -145,10 +145,6 @@ | |||
| <RelativeBlobPath>$(InstallersRelativePath)workloads/%(Filename)%(Extension)</RelativeBlobPath> | |||
| <PublishFlatContainer>true</PublishFlatContainer> | |||
| </ItemsToPush> | |||
|
|
|||
| <!-- Source build intermediated packages will be pushed and signed by the sourcebuild leg. --> | |||
There was a problem hiding this comment.
Now that we aren't pushing a copy of the source-build artifacts into the IntermediateArtifacts artifact, we can remove this code that filters it out.
directhex
approved these changes
Apr 12, 2024
hoyosjs
reviewed
Apr 12, 2024
| # as a stash of a shallow cloned repo is not currently supported. | ||
| ${{ if ne(parameters.isSourceBuild, true) }}: | ||
| fetchDepth: $(checkoutFetchDepth) | ||
| fetchDepth: $(checkoutFetchDepth) |
There was a problem hiding this comment.
SourceBuild has never had this set (due to the comment above).
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
…nd shift implementation responsibility to those scenarios (dotnet#100115)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses Arcade defaults (defaults to false/empty string) to remove richCodeNavigation property.
Inline CodeQL injection to the CodeQL pipeline
Use Arcade's Source-Build jobs now that we aren't using any features that require the steps support.
CodeQL run at https://dev.azure.com/dnceng/internal/_build/results?buildId=2411429&view=results
Official Build at https://dev.azure.com/dnceng/internal/_build/results?buildId=2411430