-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove various single-scenario YAML parameters in our build scripts and shift implementation responsibility to those scenarios #100115
Remove various single-scenario YAML parameters in our build scripts and shift implementation responsibility to those scenarios #100115
Conversation
…nd shift implementation responsibility to those scenarios. Uses Arcade defaults to remove richCodeNavigation property. Inline CodeQL injection to the CodeQL pipeline Use Arcade's Source-Build jobs now that we aren't using any features that require the steps support.
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable if official build passes
parameters: | ||
platforms: | ||
- name: CentOS8 | ||
targetRid: centos.8-x64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't CentOS EOL soon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but I wanted to preserve existing behavior in this PR to limit possible issues.
@@ -145,10 +145,6 @@ | |||
<RelativeBlobPath>$(InstallersRelativePath)workloads/%(Filename)%(Extension)</RelativeBlobPath> | |||
<PublishFlatContainer>true</PublishFlatContainer> | |||
</ItemsToPush> | |||
|
|||
<!-- Source build intermediated packages will be pushed and signed by the sourcebuild leg. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come this changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we aren't pushing a copy of the source-build artifacts into the IntermediateArtifacts artifact, we can remove this code that filters it out.
# as a stash of a shallow cloned repo is not currently supported. | ||
${{ if ne(parameters.isSourceBuild, true) }}: | ||
fetchDepth: $(checkoutFetchDepth) | ||
fetchDepth: $(checkoutFetchDepth) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who sets this for SB?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SourceBuild has never had this set (due to the comment above).
…nd shift implementation responsibility to those scenarios (dotnet#100115)
Uses Arcade defaults (defaults to false/empty string) to remove richCodeNavigation property.
Inline CodeQL injection to the CodeQL pipeline
Use Arcade's Source-Build jobs now that we aren't using any features that require the steps support.
CodeQL run at https://dev.azure.com/dnceng/internal/_build/results?buildId=2411429&view=results
Official Build at https://dev.azure.com/dnceng/internal/_build/results?buildId=2411430