Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlobBuilder.LinkSuffix/LinkPrefix need to Free zero length chunks #100039

Merged
merged 4 commits into from
Apr 5, 2024
Merged

BlobBuilder.LinkSuffix/LinkPrefix need to Free zero length chunks #100039

merged 4 commits into from
Apr 5, 2024

Conversation

pedrobsaila
Copy link
Contributor

Fixes #99266

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 20, 2024
This was referenced Mar 30, 2024
Closed
Open
Closed
@buyaa-n buyaa-n requested a review from jaredpar April 3, 2024 20:16
@build-analysis build-analysis bot mentioned this pull request Apr 5, 2024
Closed
buyaa-n
buyaa-n approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pedrobsaila!

@buyaa-n buyaa-n merged commit fc9ab41 into dotnet:main Apr 5, 2024
85 of 87 checks passed
@pedrobsaila pedrobsaila deleted the 99266 branch April 5, 2024 22:23
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@pedrobsaila @matouskozak
BlobBuilder.LinkSuffix/LinkPrefix need to Free zero length chunks (do…
76effb1 
…tnet#100039)

* BlobBuilder.LinkSuffix/LinkPrefix need to Free zero length chunks

* free child blob list

* fix remarks 1

* add unit tests
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tmat tmat tmat left review comments

@jaredpar jaredpar jaredpar approved these changes

@buyaa-n buyaa-n buyaa-n approved these changes

Assignees
No one assigned
Labels
area-System.Reflection.Metadata community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BlobBuilder.LinkSuffix/LinkPrefix need to Free zero length chunks
4 participants
@pedrobsaila @tmat @jaredpar @buyaa-n