-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono] Failing runtime JIT/SIMD/Vector3Interop_r/ro tests on osx-arm64. #96051
Labels
area-Codegen-JIT-mono
area-Interop-mono
disabled-test
The test is disabled in source code against the issue
in-pr
There is an active PR which will close this issue when it is merged
Milestone
Comments
matouskozak
added
the
disabled-test
The test is disabled in source code against the issue
label
Dec 15, 2023
vargaz
added a commit
to vargaz/runtime
that referenced
this issue
Dec 16, 2023
…m64+ios/macos. Part of the fix for dotnet#96051.
ghost
added
the
in-pr
There is an active PR which will close this issue when it is merged
label
Feb 11, 2024
vargaz
added a commit
to vargaz/runtime
that referenced
this issue
Feb 23, 2024
…ts on arm64. Vector3 was assumed to have size 16 and alignment 8, which caused problems when calling llvm compiled methods which assumed it was 12/8. Fixes dotnet#96051. Previously, different sizes/alignment where used in the pinvoke/non-pinvoke cases, causing problems with calling llvm compiled methods which always
@lambdageek should #96079 have fixed this? |
That PR only fixed the JIT. Interpreter still needs work, I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-Codegen-JIT-mono
area-Interop-mono
disabled-test
The test is disabled in source code against the issue
in-pr
There is an active PR which will close this issue when it is merged
Failures in
JIT/SIMD/Vector3Interop_r/ro
on osx-arm64 with miniJIT and interpreter.Log:
The same tests are passing on
runtime
osx-x64 miniJIT/interpreter and linux-arm64 miniJIT CI pipelines.Could be related to Mono missing support for passing Vectors in SIMD registers (#60068) and/or missing intrinsics support for
System.Numerics.Vector3
(#81501).No longer failing on osx-arm64 miniJIT after #96079.
The text was updated successfully, but these errors were encountered: